Rules Hub
Coding Rules Library
Prefer explicit checks for non-default variants
Check explicitly for specific variants instead of relying on negative checks against a default. This ensures a safe fallback for undefined or future values.
Bad example
| 1 | // BAD: Implicitly treats undefined, null, or unknown values as 'Kapital' |
| 2 | const logo = product !== 'Finansavisen' |
| 3 | ? 'KapitalLogo' |
| 4 | : 'FALogo'; |
Explanation (EN)
Using a negative check (`!== 'Finansavisen'`) means that if `product` is undefined, null, or a new future value, the code incorrectly defaults to the specific variant logic ('KapitalLogo').
Objašnjenje (HR)
Korištenje negativne provjere (`!== 'Finansavisen'`) znači da ako je `product` undefined, null ili neka nova buduća vrijednost, kod neispravno primjenjuje logiku specifične varijante ('KapitalLogo').
Good example
| 1 | // GOOD: Explicitly opt-in to specific variants, defaulting to 'Finansavisen' |
| 2 | const logo = product === 'Kapital' || product === 'Motor' |
| 3 | ? 'KapitalLogo' |
| 4 | : 'FALogo'; |
Explanation (EN)
Explicitly checking for specific variants (`Kapital`, `Motor`) ensures that any unknown, missing, or future value safely falls back to the default ('Finansavisen') rather than accidentally triggering variant behavior.
Objašnjenje (HR)
Eksplicitna provjera specifičnih varijanti (`Kapital`, `Motor`) osigurava da svaka nepoznata, nedostajuća ili buduća vrijednost sigurno pada na 'default' ('Finansavisen') umjesto da slučajno aktivira ponašanje varijante.