Rules Hub
Code Ruleset
← Back to all rules
Rule priority, scope & exceptions
Use this to align rules with the senior-level structure (P0/P1/P2, scope, exceptions/tradeoffs).
frontend ruleP0universalStack: javascript
bugternaryconditionlogic
Don't put a constant on the left of a ternary condition
Compare the input to each intended constant; a bare constant condition may be always truthy or always falsy.
PR: frontpage-web · org-mining-hist-2026-06Created: Jun 18, 2026
Bad example
Old codetypescript
| 1 | const type = hint.type === TYPE.RECENT ? 'recent' : TYPE.TRENDING ? 'trending' : 'autocomplete'; |
Explanation (EN)
A constant test cannot distinguish the changing input variants.
Objašnjenje (HR)
Good example
New codetypescript
| 1 | const type = hint.type === TYPE.RECENT ? 'recent' : hint.type === TYPE.TRENDING ? 'trending' : 'autocomplete'; |
Explanation (EN)
Objašnjenje (HR)
Notes (EN)
Check that each conditional compares the changing value against the intended constant rather than testing the constant itself.
Exceptions / Tradeoffs (EN)
Some enum constants are zero or empty and therefore always falsy, not truthy. Either constant branch is suspicious unless intentional feature gating is documented.